square/KIF — pull request #181 by matvore (2012-12-15 09:21:24+00:00)
Title: Remove call to |stepFailed| in the KIFTestCondition macro

This call is not strictly necessary because it is also being made in
|KIFTestController _advanceWithResult:error:|. It is also inconsistent
because:

* the KIFTestWaitCondition macro does not call |stepFailed| itself.
* the macro originally didn't make any assumptions about local
variables when it is being called, as the error parameter must be
passed explicitly. This allowed you to use the macro in more
contexts (see below).

Without this change, you cannot define a step execution block inline
in a scenario method. This worked before but was broken by:
http://goo.gl/0AKuT

Example:

@implementation KIFTestScenario (MyScenarios)

+ (id)scenarioToDefineExecutionBlock {
...
[scenario addStep:[KIFTestStep stepWithDescription:@"..."
executionBlock:^(KIFTestStep *step, NSError **error) {
KIFTestCondition([foo bar], error, @"[foo bar] should be YES");
}]];
...
}

@end