aeolusproject/conductor — pull request #256 by n1zyy (2012-12-13 22:51:49+00:00)
Title: BaseImages#show, take 2

This is an update to https://github.com/aeolusproject/conductor/pull/235

* The whitespace errors Jan found should be fixed
* `list_for_user` is used to filter provider accounts displayed
* I corrected the COMPLETE/COMPLETED constant value
* Imported images cannot be build/pushed
* I implemented a `build_all` method in the BaseImagesController. That's not 100% relevant to listing images, but as Jan points out, it's quite helpful to testing.
* As a bonus, I found and fixed a bug preventing users from selecting anything other than the most recent ImageVersion. I squashed it into the commit the bug was introduced in, so there's no trace that it ever happened :angel:

The issue Jan noted with calling `imported?` on a ProviderImage and working our way up a few ancestors to check BaseImage's status is is ultimate a Tim bug/RFE, IMHO. I thought about redeclaring the method locally, but I'd rather just get it fixed in Tim.