dejw/vip — pull request #15 by Juntalis (2012-12-12 05:33:19+00:00)
Title: test_should_return_best_valid_executable failing on Python 3.2

It's actually kind of weird that this didn't also fail on 2.7, but apparently 2.7 doesn't consider empty strings to be part of a string list, and 3.2 does.

[vip]$ nosetests-3.2.exe -v
test_should_call_command (vip.test.test_core.TestCommandExecution) ... ok
test_should_propagate_SIGINT (vip.test.test_core.TestCommandExecution) ... ok
test_should_propagate_status_code (vip.test.test_core.TestCommandExecution) ... ok
test_should_raise_VipError_when_CalledProcessError_is_found (vip.test.test_core.TestCommandExecution) ... ok
test_should_raise_VipError_when_command_is_not_found (vip.test.test_core.TestCommandExecution) ... ok
test_create_virtualenv (vip.test.test_core.TestCreateVirtualenv) ... ok
test_empty (vip.test.test_core.TestGetRequirementsFilenames) ... ok
test_prefix_and_version (vip.test.test_core.TestGetRequirementsFilenames) ... ok
test_should_raise_VipError_when_no_vip_is_found (vip.test.test_core.TestVipDirectoryFinder) ... ok
test_should_return_absolute_path_to_vip_directory (vip.test.test_core.TestVipDirectoryFinder) ... ok
test_should_skip_vip_which_is_no_directory (vip.test.test_core.TestVipDirectoryFinder) ... ok
test_should_raise_VipError_when_no_executable_is_found (vip.test.test_core.TestWindowsFindExecutable) ... ok
test_should_return_best_valid_executable (vip.test.test_core.TestWindowsFindExecutable) ... FAIL
test_should_return_valid_path_to_executable_with_extension (vip.test.test_core.TestWindowsFindExecutable) ... ok
test_should_return_valid_path_to_executable_without_extension (vip.test.test_core.TestWindowsFindExecutable) ... ok
test_should_return_valid_path_with_executable_extension (vip.test.test_core.TestWindowsFindExecutable) ... ok
test_should_raise_VipError_when_no_vip_is_found (vip.test.test_core.TestWindowsVipDirectoryFinder) ... ok
test_should_return_absolute_path_to_vip_directory (vip.test.test_core.TestWindowsVipDirectoryFinder) ... ok
test_should_skip_vip_which_is_no_directory (vip.test.test_core.TestWindowsVipDirectoryFinder) ... ok
test_import (vip.test.test_main.TestMain) ... ok

======================================================================
FAIL: test_should_return_best_valid_executable (vip.test.test_core.TestWindowsFindExecutable)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Development\py.thirdparty\my-forks\vip\vip\test\test_core.py", line 182, in test_should_return_best_valid_executable
self.assertEqual(expected, exe_path)
AssertionError: 'C:\\Development\\py.thirdparty\\my-forks\\vip\\vip\\test\\fixtures\\test5\\.vip\\Scripts\\command_with_better_executable.bat' != path('C:\\Development\\py.thirdparty\\my-forks\\vip\\vip\\test\\fixtures\\test5\\.vip\\Scripts\\command_with_better_executable')

----------------------------------------------------------------------
Ran 20 tests in 0.167s

FAILED (failures=1)