ese-unibe-ch/ese2012-team5 — pull request #54 by zombiecalypse (2012-12-10 12:10:30+00:00)
Title: Reviewed every non-test file

1. Use modules not classes, if there are no instances.
2. Try to avoid nesting of `if`s for example via early returns or by factoring out helper methods.
3. Documentation
* for controllers
* for classes of models
4. multiline blocks use `do ... end` instead of `{ ... }`
5. Assignments in views need to be avoided. Use `each_with_index` or other array functions. Or put stuff into the controller.
6. Put session messages in the layout.haml to avoid repeating yourselves