silverstripe/sapphire — pull request #1007 by simonwelsh (2012-12-08 11:34:14+00:00)
Title: Add codesniffer that ensures indentation is with tabs

Changes should be purely whitespace based, apart from .travis.yml and tests/phpcs/ruleset.xml.

The change to .travis.yml is removing the conversion of tabs into 4 spaces. Without this, this sniff can't be used.

From my understanding of the coding conventions, it also means the line-length sniff matches better as a tab's treated as a single character instead of four, with the 4 seeming to be a magic number that isn't mentioned at all.

I'll be providing a patch for cms and, if it's needed, a separate one for master later this week.