openshift/origin-server — pull request #1040 by brenton (2012-12-07 17:33:10+00:00)
Title: Fixing some init scripts to make the product release tests happy

In order to release OpenShift Enterprise all packages must pass the automated standards tests. They state that running 'stop' on a service script should not report FAILED if the service was already stopped. Previously these service scripts would report the correct exit code were printing the failure message.

Now we wrap the killproc call with a test for the pid. The killproc call won't work if the pid is missing anyway.

NOTE: It's true that you don't have to look far to see counter examples of this in packages (the openshift-broker and console scripts were based on apache's) but since we are a new product we are expected to adhere to the latest standards.