zberentey/liferay-portal — pull request #185 by laszlocsontos (2012-12-06 16:10:53+00:00)
Title: [TECHNICAL SUPPORT] LPS-31259

Closing this because:

1) Please change the typos in SitesUtil (mergeLayoutSetProtypeLayouts should be called mergeLayoutSetPrototypeLayouts). I know the public method was not your doing, but still...

- Done

2) Use a protected method instead of a private

- Done

3) Do not name local variables with an underscore. That is reserved for private members. Call them e.g. layoutSetPrototypeGroup and sourcePrototypeLayout.

- Done

4) There is no need to get the UnicodeProperties if you're only getting one property from them. There is a getTypeSettingsProperty() method on layout for that reason (I know you just copied that part, but you can change it now :))

- Done

5) Please rename LayoutExportImportTest to LayoutSetPrototypeTest and add some method for testing what you have just fixed.

- Done, but I think that using "LayoutSetPrototypeTest" breaks the existing naming convention (please take a look into package com.liferay.portal.lar).

Cheers,
Laci.