etsy/logster — pull request #33 by elasticdog (2012-12-04 23:38:04+00:00)
Title: Remove broken Makefile

I believe the Makefile in its current form is broken and should be removed.

1. The Makefile uses hard-coded paths rather than standard conventions like prefixing paths with `$(DESTDIR)`, which allows for packaging by easily altering the installation directory.
1. The Makefile is incomplete and does not include additional targets beyond a rudimentary install target; so uninstalling is more difficult than it should be.
1. The logster binary is installed under _/usr/sbin_, which is inconsistent with the `setup.py` installation putting it under _/usr/bin_.
1. Installing `logster_helper.py` and the parsers under _/usr/share/logster_ does not mean they'll be in your Python path.
1. There's no need to create the _/var/log/logster_ directory, as it is handled by the main binary.

The Makefile could be fixed, but it's probably better to just use `setup.py` or packages.