simonmcc/puppet-logstash — pull request #2 by tsc-nemeses (2012-12-04 12:32:17+00:00)
Title: Introduce strategy pattern for shipper configuration

Hi!

I saw your TODO-comment in shipper.pp regarding the hard-coded configuration values (logfiles). To fix this, I introduced a strategy pattern for the shipper configuration.

There are currently two strategies available:

1) The default strategy : same behaviour as before

2) The shared configuration (using the puppet-concat module): allows other modules to modify the shipper-configuration if they want (see the defines in the manifest/shipper/sharedconfig folder).

Parameters can be passed as hash to the strategy class (see the shipper.pp).

If you find this approach nice, it would be cool to get your OK for this pull request. Otherwise, feedback is very welcome! ;)

Cheers,Tobias