marijnh/CodeMirror — pull request #1034 by mattpass (2012-12-02 15:59:27+00:00)
Title: White BG as default

4 of the themes do not have a background defined and as the CodeMirror class doesn't either, the background of parent DOM elems are visible, a problem when you have a parent BG that is dark.

To see this in action, set style="background: #000" on the body tag of http://codemirror.net/3/demo/theme.html. You can now no longer read all text on the default, eclipse, elegant or neat themes.

Rather than add a white background to these themes, it is better to have a white background on the CodeMirror class itself, to provide a white base level. This of course can be overridden by the user if they wish.