MichaelKohler/HelperTools — pull request #11 by MarkyV (2012-12-02 21:57:38+00:00)
Title: Completed validation to prevent null pointers and fixed a bug

Hello, I completed the work I began in my last pull request by using the Validator class to check arguments for all public methods that seemed to need it. I approached this with a test-driven development style by adding tests first and then code, this can be seen in the commit log (I didn't want to have any part of my commit have broken tests, so I did a squashed commit).

I also fixed a bug in FileHelper (well, depending on intended usage). I discovered that, for the makeFile(String... path) method, if you pass it two arguments, it will call itself due to an extra if condition and do so repeatedly as the if condition is always reached until a stack-overflow occurs. I just deleted the if condition, but I'm wondering why it was added in the first place, if maybe it was meant to call a different method (like the makeFile with an append argument), then this might need to be fixed more.

Let me know if there are any concerns. Thanks!