hdgarrood/value_object — pull request #1 by semanticart (2012-12-01 14:09:49+00:00)
Title: Resolving some warnings

Greetings! This looks like a useful library.

I'm submitting a pull request to resolve a couple warnings I bumped into when I ran the tests with RUBYOPT=-w rake:

lib/value_object.rb:11: warning: `*' interpreted as argument prefix
lib/value_object.rb:16: warning: method redefined; discarding old fields
activesupport-3.2.8/lib/active_support/core_ext/class/attribute.rb:97: warning: previous definition of fields was here

The first one is easily fixed by adding parens to the attr_reader. The second one is fixed by deleting unnecessary code since the fields method is defined as part of the `class_attribute :fields` at the top of the Base class.

Rerunning the tests again with verbose mode results in no warnings in value_object.

Thanks!