TShock/TShock — pull request #466 by Scavenger3 (2012-11-30 07:26:30+00:00)
Title: Fix SilentKickInProgress

nicatron's commit:
https://github.com/TShock/TShock/commit/d01ae01468f6b53abba529f457326c5d2a983c32

nicatron's commit will broadcast the leave message if the player's state is >= 2 regardless of SilentKickInProgress. It is also doing the same check twice for > 1, however in the commit nicatron says "if their state is > 2"

looking at the messageBuffer, the player's state gets changed to 3 before they get sent tile selection: https://github.com/Deathmax/TerrariaAPI-Server/blob/master/Terraria/messageBuffer.cs#L380

nicatron says: May lead to a fix for players already being on the server that haven't yet accepted world data.

therefore I would assume it should be > 2