sahlberg/libiscsi — pull request #48 by plieven (2012-11-30 07:49:41+00:00)
Title: iov write important upstream fixes

This fixes the segfaults and output stalls already committed earlier to upstream/zero-copy-write-2.

I would currently wait with merging

007ac2558f880aac4ea8d05ce3a90d38017a7f88

because I am not sure that it is really a bad idea to send the header first and then the payload (even for small packets). If I image how the code in the target might look like it will first read the header and then read the payload as we do in iscsi_receive_from_socket().

What we should definetely look into is the following. I have observed that open-iscsi sets the PSH tcp flag on any outgoing packet. It might be a good idea to set it at least after the whole PDU has been transmitted or maybe also after the pdu header has been sent for the above reasons. Or set it anytime like in open-iscsi.