basho/riak_test — pull request #103 by jrwest (2012-11-29 20:05:48+00:00)
Title: Port regression_az1018.py

Verify `busy_dist_port` messages appear in logs (riak_sysmon default configuration is setup properly).

A couple gripes I have w/ the implementation of this test:
* It uses timer:sleep (like the original b_e test) to wait between periodic checks of `console.log` for `busy_dist_port` messages. Tried to address this by checking up to a max number of times and sleeping for some interval in-between. This should at least mitigate the problem of slower vs. faster machines a bit. The numbers chosen are somewhat arbitrary but the original test slept for 2 seconds before checking and I figured 1 minute total w/ no messages is long enough before considering the test a failure.
* grep is executed via `rpc:call` & `os:cmd/` which doesn't return an exit code, so if the file does not exist, naive handling of the result from `grep` can cause false positives. There is a not-so-lovely hack in place to handle this but the proper solution would be to use a port (similar to `rt:spawn_cmd` but adjusted to run on the riak node not the rtdev node)

https://github.com/basho/riak_test/issues/39