rollerworks/RollerworksRecordFilterBundle — pull request #5 by sstok (2012-11-27 14:02:27+00:00)
Title: [WIP] Refactored MessageBag and FilterTypeInterface

Bug fix: no
Feature addition: yes
Backwards compatibility break: YES!
Tests pass: yes
Todo: Update documentation
License of the code: MIT

An filter-type no longer uses the $message parameter but uses $messageBag (MessageBag instance).
And based on the existence of error messages the validation state is determined.
This change makes it more in-line with the Validator component.

MessageBag API has changed addError() and addInfo() is now always translated.
The $addTranslatorPrefix parameter is removed, and added support for plural messages.

And last, the default domain for addError() is changed to 'validators'.

This a big Backwards compatibility break but I believe its worth it.
Using a $message parameter reference while the MessageBag must always be provided is not very clean so changing this will provide us with a much cleaner API.

I'll be tagging a patch version before this merge so any one using the Bundle at this state can reference it then and upgrade later.