razorsedge/puppet-network — pull request #13 by dmangot (2012-11-27 21:53:40+00:00)
Title: cleaned up to conform to style guide via puppet-lint --no-only_variable_...

...string-check

Actually, I turned off a few checks.
--no-autoloader_layout-check
--no-80chars-check
--no-only_variable_string_check

I did NOT run this against the rspec tests but I don't think I broke anything, every .pp file passes puppet parser validate on 2.7.19.

This should make most everything conform to the style guide at http://docs.puppetlabs.com/guides/style_guide.html.

The only thing I really had a question about was things like:
network_if_base { "${title}":

That looks right to me but the linter complains about quoting only a variable. If you wanted to fix those up, there are only 6 of them.

./manifests/bond/alias.pp - WARNING: string containing only a variable on line 30
./manifests/bond/dynamic.pp - WARNING: string containing only a variable on line 29
./manifests/bond/static.pp - WARNING: string containing only a variable on line 37
./manifests/if/alias.pp - WARNING: string containing only a variable on line 36
./manifests/if/dynamic.pp - WARNING: string containing only a variable on line 37
./manifests/if/static.pp - WARNING: string containing only a variable on line 45

We're using this module and it's making our git pre-commit hook check go nuts, that's why we wanted to clean it up. Hope you find it useful.

Let me know if you have any questions/concerns or if you need me to fix/change/explain something.

Cheers,

-Dave