weavejester/clout — pull request #10 by tom-b (2012-11-26 15:52:05+00:00)
Title: Allowing semi-colon and commas in path portions of requests?

Hi,

Would you be open to allowing the semi-colon and comma characters in paths?

I believe this is ok from a standards perspective:

http://tools.ietf.org/html/rfc3986#section-3

and is a one-line change in core.clj (line 128)

word-regex #(regexs (word-group %) "[^/?]+")]

I ran against the existing test suite and it looks like all tests pass.

This would allow for requests like:

put "/resources/1;2;3/k1/v1

(PUT "/resources/:ids/:k/:v" [ids k v]

to match and destructure successfully - they currently do not.

Thanks - if you need me to do something in the tests or come up with documentation, I can try to add that as well, just not sure what you would prefer. BTW, thanks much for the awesome web-app tools.