kennethreitz/requests — pull request #956 by Lukasa (2012-11-24 21:44:17+00:00)
Title: Try to resolve OAuth+JSON problems.

This is an attempt to solve issue #910 (and hopefully #896 by association).

This solution is unlikely to cause a regression except in one specific case, where the form data _is_ urlencoded but doesn't have the correct Content-Type header set. If we think that's a likely scenario, I can go back and make the test for that case less restrictive. The flip side is that we will not mistakenly include data we shouldn't.

There aren't any tests for OAuth functionality in Requests, so I have no idea if this makes things worse or better. My local tests seem to suggest that everything is ok though, so let's assume it's all awesome. =D

NB: I'm aware that we've moved the OAuth stuff to requests/requests-oauth. I'll raise an equivalent PR over there if we decide to use this one, but there are a few open issues here that make raising this PR here useful as well.

@idan: Does this look right to you?
@michaelhelmick: Does my branch resolve your issues?