ci-bonfire/Bonfire — pull request #651 by sourcejedi (2012-11-23 18:15:45+00:00)
Title: add post_key_exists(), use it to test for submit buttons

I'll merge this soon. It can always be reverted. If anyone wants to comment (after or before I merge it), that would be great.

The first commit gets ctrl+s working again (issue #645).

The second commit adds a new method `$this->input->post_key_exists()`. It's the cleanest way I could find to handle submit ``s, where IE7 doesn't submit the value attribute. Previously I've been testing e.g. `isset($_POST['delete'])`, but I dislike the inconsistency (where the rest of the code was testing for `$this->input->post('submit')`). So this commit converts the tests in all controllers to the new method. I hope this will make the code easier to read, maintain, contribute to etc.

This includes the controllers generated by the module builder. (So I'd better start looking at the new builder repo...)