simonw/geocoders — pull request #3 by bquinn (2012-11-23 00:18:25+00:00)
Title: Unicode compliant urlencode

Hi Simon, thanks for making your geocoding library available (and er thanks for Django and all that as well ;-)

I encountered a bug when taking Geonames locations (like "Pnom Pen, Krŏng Phnum Pénh, Cambodia") and then sending them back up through the geocoder using your libraries - the urlencode function used was the Python default one, rather than the Django unicode aware version. So I switched it over and it seems to work nicely.

I have only tested it with the Geonames wrapper so far but I changed all of the scripts because presumably they all work the same way. Let me know if you would like me to be a bit more rigorous about that before accepting the request!

Thanks again,

Brendan.