sahlberg/libiscsi — pull request #38 by aredlich (2012-11-19 19:13:56+00:00)
Title: Remove scsi_task->params

Ronnie,

Please pull from my libiscsi tree: github.com:aredlich/libiscsi.git master

It contains a number of changesets that ultimately lead to the removal of the scsi_task->params union which can go away as it carries redundant information that is available via the cdb anyway.

The changesets are for the most part fairly mechanical, i.e. each struct scsi_*_params is removed by a distinct changeset, but while at it, a number of other issues (potential memory leaks, CDB field not properly set) are additionally fixed by these commits:
* scsi-lowlevel: remove scsi_readtoc_params and fix READ TOC format field
* scsi-lowlevel: remove scsi_serviceactionin_params and plug potential memleaks
* scsi-lowlevel: remove scsi_inquiry_params and refactor INQUIRY data-in unmarshalling

Finally, there is a changeset to include in iscsi.h as the latter now uses size_t's.

Largely only compile tested.

Thanks,
Arne