yayitswei/jida-worker — pull request #1 by sgrove (2012-11-19 16:32:28+00:00)
Title: DO NOT MERGE: Tidy up branch

Thought I was doing a minor refactor, but lead down an all-day rabbit hole.

Cleaned up some definitions, split out the methods to be smaller, tidied up a bit. Would love to hear your thoughts on the naming/legibility of the code, small as it is.

Biggest part is that I brought in codeq as a jar so we can use it programmatically without shelling out. The code looks lovely with it, but it turns out that https://github.com/Datomic/codeq/blob/master/src/datomic/codeq/core.clj#L256 doesn't allow us to pass in the correct ENV, so codeq just runs on the existing directory and re-imports jida-worker.

I like the new code a lot, but wonder if:

1. We'd have to fork codeq, make the tiny change in a few functions so the env is providable, and it's more modular in general.
1. We can make a helper function that does all that itself inside of jida-workers

Not that we have to go this route, just curious about the problem.