libgit2/libgit2 — pull request #1086 by scunz (2012-11-19 04:29:08+00:00)
Title: VS-Build: Append C_FLAGS to the end of the already given ones.

My other PR #1085 revealed, that the /W4 parameter, we give to MSVC is ignored
because cmake set CMAKE_C_FLAGS already to /W3 and we overwrite it.

The command line tools gave me a D9025 warning for this on every file and
looking into the project properties page on MSVC 2008 tells, that it has
the warning level set to /W3.

I'm uncertain if you really want /W4. It produces ~150 warnings more on
a 64bit build. Some of them (i.e. C4706) are really nasty and totally
needless. OTOH if we can only find one real issue with it, it might be worth it...