aushack/metasploit-framework — pull request #1 by todb-r7 (2012-11-17 22:17:16+00:00)
Title: Reverting msftidy changes via a checkout

Generally speaking, you should not be editing many disparate files and landing them all on one commit, much less on one pull request. This makes it exceedingly difficult to revert or change your changes down the road in the event of bugs or undesired features or whatever.

Anyway, I'm not ready to change msftidy yet, and I'm pretty sure the reasons have been hashed out on https://github.com/rapid7/metasploit-framework/pull/1074

I would like to see the changes on modules/exploits/windows/browser/ms05_054_onload.rb on a separate commit as well, but i'm not going to make a federal case out it right now. The original pull request should have mentioned it specifically. Right now, in order to tell what you're trying to fix there, I have to read code, like, with my eyeballs, and who has time for that? :)