yireo/SimpleLists — pull request #1 by Twentronix (2012-11-15 22:09:35+00:00)
Title: # Missing <tr> and </tr> fixed for table.php template

Hi Jesse,

Thanks for your quick reply. Github is indeed better.
> On the issue you are addressing: The SimpleLists component uses a if-else function to check whether there are any items. If there are no items, no table is printed is in the first place. No table-rows are ever printed empty, unless SimpleLists is configured or modified to show nothing per item.
I agree with you that nothing is outputed if the items are empty:
> items)) : ?>

However, when there are items and $i % columns is not 1, there is not a
inside the

. This happens e.g. if you only use 1 column. There should be always a table row inside the

if you're outputting a table, so this check should be removed:
>
>

>

Likewise for the closing part:
>
>

>
Could you please give it a look? Thanks in advance.

--
Best regards,
Jurian Even

Twentronix
Joomla! Extensions Developer