FlorianRappl/YAMP — pull request #2 by cureos (2012-11-13 16:35:03+00:00)
Title: Replacing Hashtable

Dear Florian,

many thanks for making your excellent YAMP library publicly available.

I am interested in using the library in a Windows Store (a.k.a. Metro) application, and therefore I am currently examining the possibility of building the library as a so-called Portable Class Library (targeting the library for .NET 4+, Silverlight 4+, WP7+ and Windows Store applications).

One obstacle is the current use of the `Hashtable` class in the original YAMP library, since `Hashtable` is not included in the Portable Library sub-set. To be able to build the library as a portable library it is necessary to replace `Hashtable` e.g. with a `Dictionary<>`.

I have forked your repository, and in my fork I have replaced all uses of `Hashtable` with `Dictionary`. The project builds with this update, and I can successfully run your console application, so at first sight this update does not seem to have broken anything.

I am making this pull request in case you find my update valuable for your project as a whole. If you believe that the dictionary can be more fine-grained than containing `object` values, I am more than willing to provide a further update.

If you do not see any added value with this pull request to your own development, you can simply leave it without notice (i.e. close it).

I have not yet completed the adaptation to a portable library, the `Parser` class is using a `BackgroundWorker` derivative that is also not supported in PCL. When I have a running portable YAMP library, I'll let you know.

Best regards,
Anders Gustafsson @ Cureos