xni/socorro — pull request #2 by twobraids (2012-11-13 15:18:35+00:00)
Title: thorough limiting of signature length

I agree that the signature trimming code has a problem. Your solution is effective, but I'd like to see a more thorough solution. The signature generation tool already has a concept of the maximum length. Unfortunately, the processor modifies the signature after the signature tool has finished its work.

In this PR, I've modified the signature tool to expose a length limiting function. Then I have the processor use that function after it has modified the signature. This method of resolving the problem keeps the maximum signature length as a configurable parameter.

This PR also makes changes to the upcoming new processor that I hope will be in use by the end of the year.

Check out my solution and test it to see if it resolves the problem that you see. If it works for you, feel free to integrate my changes into your pull request.