diaspora/diaspora — pull request #3715 by brauliomartinezlm (2012-11-08 01:57:26+00:00)
Title: Issue #3663: [Refactor] Remove posts#new action

This pull request addresses issue #3663 ( https://github.com/diaspora/diaspora/issues/3663 )

I removed the action in the controller, the route that pointed to it (as it was not used anymore), a view that wasn't used either, related code in backbone side (by the way Composer page didn't exist anymore).

Finally I deleted a controller test on status_message that hit with a GET against new_bookmarklet (name of the view that I deleted). This route didn't even exist, the only reason why this test wasn't failing already is because of the way of Rails works while testing. Rails doesn't need an action to be defined as long as the template exists. I'll put my source reference in case someone, while reviewing this, asks himself the same questions that I ran through with this test (it was a tricky one to remove because it failed only when I removed the view and that seemed weird).

Also I've got rid of some not cool whitespaces in the way :-)