SaltwaterC/aws2js — pull request #67 by dcleal (2012-11-06 14:57:55+00:00)
Title: Don't error on close event 204

AWS reponds with an empty body and 204 response after removing something from S3. In some such cases we get the response close event: I don't think this should be an error if the response code is 204, as we already have all the data we're going to get. Hence this two line change.

As an aside, how do you recommend developing aws2js? I don't really understand how to check it out from github and run the tests: I think I'm missing some aspect of how npm modules work. Currently, I do something like

mkdir foo;cd foo
npm install lodash@0.8.2 libxmljs libxml-to-js http-get aws2js
cd node_modules; ./tools/test.sh

The tests run: but I'm not editing a git checkout, so at the end, I have to copy and paste changes into a checked out aws2js branch. I guess there must be some way to just checkout the code and run the tests in situ, but I can't work it out.

And advice would be gratefully received

- Dave