saltstack/salt — pull request #2469 by thekuffs (2012-11-06 23:27:37+00:00)
Title: Fix NoneType error in file._symlink_check()

I've been getting the following error when using the `file.symlink` state:
```
----------
State: - file
Name: /etc/localtime
Function: symlink
Result: False
Comment: An exception occured in this state: Traceback (most recent call last):
File "salt/state.py", line 885, in call
File "salt/states/file.py", line 403, in symlink
File "salt/states/file.py", line 334, in _symlink_check
File "salt/states/file.py", line 192, in _error
TypeError: 'NoneType' object does not support item assignment

Changes:
```

This pull request removes the call to `_error()` for the case of a pre-existing, non-forced symlink test in `file._symlink_check()`. The call is not necessary as `file.symlink` does the return value tuple expansion itself (https://github.com/saltstack/salt/blob/develop/salt/states/file.py#L403).