sahlberg/libiscsi — pull request #34 by aredlich (2012-11-02 20:50:00+00:00)
Title: Fixes for libiscsi compiler warnings

Ronnie,

Please pull from my libiscsi tree: github.com:aredlich/libiscsi.git master

It contains a number of fixes for compiler warnings observed here (gcc-4.6.3). Besides flagging rather harmless things, these compiler warnings also brought up a few real issues, e.g.:

* "test-tool: fix initiatorname and initiatorname2 issues"
* "T0404_inquiry_all_reported_vpd: fix compiler warnings" (parens around bitops)

With all the changesets in my tree, I'm down to only a few warnings in iscsi-ls, iscsi-inq and iscsi-readcapacity16; all related to libpopt returning const char ptrs which free() does not like as arguments, e.g.:
src/iscsi-inq.c: In function 'main':
src/iscsi-inq.c:243:7: warning: assignment discards 'const' qualifier from pointer target type [enabled by default]

Since I'm not familiar yet with libpopt I left these alone for now.

Please note that these changes have seen only light testing here.

Thanks,
Arne