saltstack/salt — pull request #2418 by ffa (2012-11-01 04:38:55+00:00)
Title: Demo of saltstack/salt#2417 module standards choice "1"

I left a note in "salt/modules/git.py" for the _git_run method.

For "salt/states/git.py", the two public methods illustrate the
two different methods utilizing the proposed module standards in
a salt state.

* "git.latest" uses "try[..]catch" blocks to return the error from the module
as part of the state's return output.

* errors from modules called in "git.present" pass through to the minion which
"[...]itself does catch all published executions exceptions and returns based
on that information" [1]

As you will see, implementing the standard is quick, easy, simple, and non
invasive. In fact, most of my time was spent writing this commit message.

[1] thatch45, https://github.com/saltstack/salt/issues/2417#issuecomment-9969939