Morsgault/Java_RPG — pull request #3 by gbchaosmaster (2012-10-30 20:50:18+00:00)
Title: Code Review =D

A bit of refactoring done, fixed something. I squashed everything into one commit, for cleanliness.

The more I look at this code, ya know, the nicer I'm feeling that it'd look in Ruby. :wink:

This may be possible for ```AttackEngine::Battle()```, by the way:

```Java
public void Battle() {
elevel = elgen.nextInt(2)+(plevel-1);
E_HEALTH = EC_HEALTH = 70 + (elevel + 1) * 30;
}
```

Since there aren't any unit tests, I won't risk it though, because Java can act stupid.

I'll assume that you have a plan for ```LocationDescription```, because right now the entire file could be reduced to this:

```Java
public class LocationDescription {
public String getDescription(int x, int y) {
return "You are in a forest.";
}
}
```

I didn't touch it, though, because it looks like it's slated to expand in the future.

If you catch anything that you wanted nasty for a reason, let me know and I'll roll back that particular change.