sbadia/puppet-gitlab — pull request #15 by sroegner (2012-10-29 16:33:57+00:00)
Title: Restructuring to fix scoping issues

Sebastien,

I put some work into getting the scoping fixed before I start on the Redhat part because I want to work on puppet3 which is more strict there.

I had to make one significant change - rename gitlab::gitlab to gitlab::server. The reasoning is that naming the class that way creates an ambiguity - there is also a gitlab class in init.pp which is auto-loaded as gitlab::gitlab. I also did away with most of the inheritance which I think is not really needed, but I might be wrong there.

In any case it would help me a great deal if you could pull all this even though it is a lot of changes. The current status of this code is that puppet runs successful up to 'bundle install' at which point the installation of eventmachine fails - a well-known problem on gitlabhq. How do you deal with that?

Cheers,
Steffen