puppetlabs/puppet — pull request #1243 by zaphod42 (2012-10-30 00:29:52+00:00)
Title: (#17260) Issue warning for hypens in variables

In commit b26699a2, daniel-pittman fixed an accidentally introduced change to
the lexer, allowing `-` to be part of a variable name. That had lasted for a
while and was surprisingly popular. It was also hugely ambiguous around `-` as
minus, and led to all sorts of failures - unexpected interpolations to nothing
- because of that.

This adds the ability to turn hypens back on in the lexer, but issues a
deprecation warning when they are used. By default hyphens are still turned
off.

Puppet 3 should not have this feature and so this change must not be merged
into the 3.0.x or master branches.