scala/scala — pull request #1532 by hubertp (2012-10-28 22:36:03+00:00)
Title: Fixes SI-5031 for separate compilation scenario.

When you have a conflicting member in package object and normal package that share the same namespace we remove the latter ClassSymbol from the scope. Now, this has an unpleasant consequence that companionClass/companionModule/companionSymbol no longer work correctly as they rely on finding the correspondent symbol using decls of the owner.
This fixes the problem of SI-5031 for separate compilation. Why the above change matters for finding foo.bar.Foo? Because when parsing the class we needed information about the static module (and we have the correct module symbol when completing the info). It's just that 043ce6d0565c9d5d960 relied on no longer valid assumptions. So we were getting NoSymbol and sym.exist was failing.

Obviously a more complete solution would be better if we didn't rely on the scope but that's too big to change for 2.10.0.

Already discussed with @odersky, but it would be great to get a quick lgtm.