jdarling/MongoMQ — pull request #4 by mfrobben (2012-10-28 02:08:48+00:00)
Title: Parameter fixup for partialCallback and completeCallback.

If an emit call is made expecting a callback when the operation is complete, and partialCallback is explicitly set to null, the completeCallback param is ignored. This cost me a few hours and want to make sure no one else runs into it.

This is correcting a symptom, but not the real problem - seems there is no such thing as a completeCallback without a partialCallback. After reading through the closure code, the partialCallback and listener are always created and used. This was only a 15 minute read of the code, but it seems unnecessary in the case where I only want a callback on completion. I'd be happy to rewrite this if we can talk through the technical design a bit on gchat.

Thanks,
~Matt