philwebb/spring-framework — pull request #1 by cbeams (2012-10-25 08:20:42+00:00)
Title: Rebase original commits for #132 and review changes for SPR-9692, SPR-9566

Phil,

A few things to review:

* The use of ExpectedException causes `NoSuchMethodErrors` for me under both Eclipse and Gradle. Presumably you're getting different results? Please run tests like `TypeDescriptorTests` to confirm, and let's figure out how to make everything work.
* `TypeDescriptor` has been made final - why? What do you think the likelihood is of this being a breaking change for people, i.e. how likely is it that folks might have extended this type?
* #132 contains commits for both SPR-9566 and SPR-9692 - why, i.e. what is the relationship between these two, i.e. why combine both in a single PR?
* both SPR-9566 and SPR-9692 have their fixVersion set for both 3.1.3 and 3.2 RC1. Given the scope of these changes, I am hesitant to backport them to 3.1.3 (still need to understand the complete impact even to 3.2). Do you have a strong case for backporting one or both?
* It appears that these changes modify the conversion algorithm to match superclasses with a higher precedence than interfaces. As per your comments in SPR-9692, this would seem to introduce a backward-compatibility problem. Do you have a rationale as to why this change is merited, i.e. that the previous behavior is simply wrong, that it is very unlikely to actually affect anyone, etc.?

In any case, this pull request rebases your commits against the latest from SpringSource/master and fixes the conflicts that cropped up along the way. As usual, just do a non-ff merge of this PR and we'll see #132 automatically update. We can continue the conversation there.

Thanks!