openSUSE/snapper — pull request #3 by oniko (2012-10-25 15:54:45+00:00)
Title: Oniko

Hi Arvin,

I'm sending you another proposal for 3 patches:

- Fix 'create-config' command to reject non-thin LVM volumes (following 'create' command for snapshots fails as expected, but maybe user should be stopped a step sooner)
- I think the check for btrfs-progs binary is useless since you're using ioctls to manipulate btrfs snapshots
- there's a tiny bug. The client aborts if you call 'diff' command w/o arguments by mistake. A simple reproducer:

rawhide/~ # snapper -c root diff
terminate called after throwing an instance of 'std::logic_error'
what(): basic_string::_S_construct null not valid
Aborted (core dumped)

With regards
Ondrej