kyleconroy/hawkthorne-journey — pull request #484 by campadrenalin (2012-10-25 00:59:12+00:00)
Title: Fix for #482 (Doors react to UP key even when inventory is open)

This is a fix for #482. As you can see, I came up with 2 possible solutions for the problem, and I ended up taking the second one, which should be better for us down the road. I didn't want to try to convert the whole codebase over to using the keyboard context system in one bugfix, especially without any sort of confirmation yet from @kyleconroy that it's something to pursue further. But hopefully this will greatly simplify the logic - and prevent bugs - in things like NPC dialog, minigames, etc.

Also, it occurs to me that we ought to move node keypress testing for player_touched into the keypress callbacks themselves, if we want to have any keypress detection in nodes that don't touch the player. But that's a job for another day!