scobal/seyren — pull request #61 by EmmanuelAcheampong (2012-10-24 18:42:30+00:00)
Title: Adding PagerDuty Notifications

This makes use of biz.neustar PagerDuty work (https://github.com/webmetrics/pagerduty-java).

Its not perfect, but that's more due to the model than the work ive added, for some reason the last change introduced to the main repo added a new method to the NotificationService.java interface - that all other notifications are supposedly meant to implement, question why you would have a sendemailstatus method you want to override in all other types of notification services?? but for now, just going to get in the changes, also need to look at the whole structure as the current model doesn't really work for anything more than one notification type of email, unless my java can be improved and we can somehow infer at runtime which notification type to fire off based on the notification type of the subscription being checked.
any improvements/comments are welcome.
sending this for PR review, by all means dont accept until we have resolved the issues i've raised, im keen on continuing to develop this tool, but don't want to see more strange model decisions taken unless without good reason, im no java guru, but can already see many things to improve.