rapid7/metasploit-framework — pull request #965 by limhoff-r7 (2012-10-24 20:44:23+00:00)
Title: Fix file_changed? argument and reloading to eliminate spurious ambigious module warning

`module_manager.file_changed?` was being called on the directory, `parent_path`, instead of the correct `module_path`, which the path was never in `module_manager.module_info_by_path`, so the `file_changed?` always returned `true` and load_module was issuing ambiguous module warnings because it was reloading when reloading wasn't needed. Additionally, the `:reload => true` option was being treated differently than `:force => true` or `module_manager.file_changed?` returning true, so warnings were being issued about reloading when they should not be.

Because of all these complications, I wrote full specs for all of `Msf::Modules::Loader::Base`.