pioneerspacesim/pioneer — pull request #1632 by johnbartholomew (2012-10-24 22:26:58+00:00)
Title: Fix remaining file access operations to go through FileSystem

**DO NOT MERGE**

This should fix #1627 and the non-text-display-related part of #1482, *except for zip files*. It builds on Linux and under my copy of MXE, but it hasn't been properly tested yet.

We really need to fix up FileSourceZip as well before this can be considered complete. This requires hooking up custom I/O to miniz. Hopefully not too difficult, but I haven't looked at the interface for it yet.

Things to test:

* Loading and saving from the old GUI file selectors.
* Quick-save.
* Loading from the new GUI file selector.
* Screen-dump.
* Redirection of the standard error streams.
* LMR model cache reading and writing.
* (when it's been updated) .zip handling.

I've checked a few of these on my ASCII-only Linux system, but they all need to be checked on multiple platforms (particularly Windows), in the context of a Pioneer config directory with non-ASCII characters in the path (e.g., äçéñťêđ characters), and for save files, non-ASCII characters in the name.

Note that characters that aren't in the texture font glyph set will still cause crashes.

As a bonus, this also makes the UI skin config file moddable, which it wasn't before.