libgit2/libgit2sharp — pull request #232 by dahlbyk (2012-10-22 03:32:14+00:00)
Title: Random Refactoring

Miscellaneous changes that came to mind while poking around...

1. Two files where we deliberately ignore C# naming conventions. If you'd rather not add R#-specific error suppression, that's cool too.

2. Setting up an equality helper's particularly noisy; `params` cleans it up muchly.

3. I started just making `defaultValue` optional, which feels right. Removing the two-part overload was necessary (and makes sense, I think) because of a conflict with the three-part overload when retrieving a `string`.

4. Consuming the `_foreach` APIs feels clumsy and repetitive, so returning a collection from `Proxy` seems like a good move. The implementation's a bit weird, though (especially the conversion between delegate types) - any suggestions are welcome.