macgitver/macgitver — pull request #45 by antis81 (2012-10-21 12:49:27+00:00)
Title: Submodule UI Module: The next step

Finally I found some time to give the submodule view another try. I kept the "Novice.GUI.xml" file local, so nothing is visible yet.

Features:
* reading of submodules in bare and normal repositories works
* ToolTip shows submodule details (URL and local relative path)

Missing:
* Because the IconProvider is not finished yet, an empty QIcon is used as a placeholder.
* As well, submodules are not read recursively.
* The current submodule status.
* instead of the ID something like "git describe" should be shown (meaning: a tag, if there is one)

Questions:
* What was the intention of the (unused) visitor pattern in "readSubmodules()"? I'd suggest to leave it out, until we really need such a thing and do the right thing then.
* To make it work, I really had to take out the "LIBGIT2_IMPROVED" workaround. Otherwise nothing will be shown. Seems very ok to me. What do you think.