sergiogonzalez/liferay-portal — pull request #399 by KocsisDaniel (2012-10-17 09:25:49+00:00)
Title: [TECH SUPPORT] LPS-30417

Hi Sergio,

this pull is regarding to the new app-view-entry tag. Currently it use a bit complicated HtmlUtil.escape(HtmlUtil.uneascape()) composition to make a valid escape because currently all the input parameters are already escaped. We had a bug regarding to the escape, and the fix would be to add more escape+unescape pairs to the taglib page.jsp. Instead I guess it is a better solution to always assume we have the input in its final format, so the caller should take care about to escape the strings. We don't have to make any other changes on the jsp's using this tag, because now the inputs already escaped with toEscapedmodel() calls.
The other solution would be a new tag attribute (escapeXml, escapedmodel or something like that) to control this behavior based on the caller needs.

What do you think?
Daniel