xbmc/xbmc — pull request #1636 by Montellese (2012-10-17 13:37:07+00:00)
Title: close CGUIDialogFooInfo dialogs on ACTION_SHOW_INFO (fixes #13139)

When executing ACTION_SHOW_INFO (by pressing "I" or the "Info" button on a remote) while residing on a media item we open the media-specific info dialog. Thanks to keyboard.xml and remote.xml xbmc also closes those dialogs again when pressing the same button but this time using ACTION_BACK. In JSON-RPC the method Input.Info() triggers the execution of ACTION_SHOW_INFO but obviously JSON-RPC doesn't (and shouldn't) know/care about the GUI state so it doesn't know that it should send ACTION_BACK when the dialog is already open. This behaviour makes it hard for remote clients to offer the same functionality as with a keyboard or a physical remote.

These changes add handling for ACTION_SHOW_INFO in OnAction() to close the dialog when it's already open. There's a bug report for it on http://trac.xbmc.org/ticket/13139 but I could understand if it's not considered a bug in XBMC. So @cptspiff the decision is up to you.