mozilla-b2g/gaia-email-libs-and-more — pull request #64 by asutherland (2012-10-16 08:00:32+00:00)
Title: Bug 799829 - [email] complete move/trash implementation

f? @mozsquib for https://bugzilla.mozilla.org/show_bug.cgi?id=799829

This is a heads-up that this review request is almost ready. IMAP moves work in the unit test and on b2g-desktop.

There is a minor regression in the other IMAP mutation unit test involving the case where we de-persist operations from disk and it's not clear whether the local mutations occurred or not. I think I can resolve that one by just relying on what we persist a little more.

This includes the ActiveSync refactorings. Move and delete have not yet been tested, but I think they should be pretty close to done. I will test them manually tomorrow. The delete code you were using did not use the DeletesAsMoves flag, we might want to add that. I forget if you had discussed its semantics with me previously.

Some of the commit messages in here are detailed and may be useful if trying to understand what's going on. Especially the early commits were about cleaning up unit test regressions, especially as they relate to time-zones.

This includes some punting on the check/undo cases for moving. I plan to get to those after this lands and we are able to close out the remaining features that we got blocker approval for.