molgenis/molgenis — pull request #75 by RoanKanninga (2012-10-16 12:51:00+00:00)
Title: fixed some critical bugs (findbugs)

View.java
This method calls equals(Object) on two references of different class types with no common subclasses. Therefore, the objects being compared are unlikely to be members of the same class at runtime (unless some application classes were not analyzed, or dynamic class loading can occur at runtime). According to the contract of equals(), objects of different classes should always compare as unequal; therefore, according to the contract defined by java.lang.Object.equals(Object), the result of this comparison will always be false at runtime.

FormController.java
Impossible cast from org.molgenis.framework.ui.MenuModel to org.molgenis.framework.ui.MenuController in org.molgenis.framework.ui.FormController.doXrefselect(Tuple)

MolgenisModelValidator.java
This instruction assigns a value to a local variable, but the value is not read or used in any subsequent instruction. Often, this indicates an error, because the value computed is never used.