mpc-hc/mpc-hc — pull request #19 by obszczymucha (2012-10-15 20:28:20+00:00)
Title: Subtitle overlapping toggle (different approach)

Hi

I'd like to add 'subtitle overlapping toggle' feature again. This feature would be enabled by default, and will keep the current behaviour of the filter, which is displaying subtitles on top of eachother when timings between subtitles are too short or overlap.

When feature is disabled (new behaviour), all subtitles will be displayed in one line.

I've taken all your comments into consideration and approached the feature differently.
My previous attempt on doing this was to correct subtitle timings, which required restarting of the filter if the user wanted to change the option. This time I'm just preventing subtitles from being displayed in more than one line.

Comparing to the previous approach:

- the feature no longer requires filter restarting
- works for both external and embedded subtitles
- interface should not break existing players (methods added as last)
- the code is (imo) less invasive

Please decide whether the project would benefit from this change. I personally found the lack of such feature in VSFilter and I've also seen people asking for such option in the web.

Regards.