openSUSE/kiwi — pull request #125 by rjschwei (2012-10-15 15:30:27+00:00)
Title: Codify the <preferences> and it's children

Sorry for the mega pull request, hope you are in the mood for massive code review ;)

There's some clean up wrk left, i.e. move all the XML*Data classes to be children of the XMLDataBase class, but that can be done easily outside of this branch once this code is in. No reason to add more stuff here, although I already started with this clean up in this branch.

I think with this code it nicely shows where the whole thing is going and it also shows the potential of simplifying the interface of the XML object as well as simplifying the code while increasing the unit test coverage and capabilities. Almost all of the code if perlcritic level 2 clean :)

Let me know if you have any questions, again sorry for the massive amount of code in this branch. The remaining pull requests for the codification of the other elements into the new data structure should be smaller.