mparrenovilla/Crappr — pull request #1 by joshmcarthur (2012-10-15 19:58:04+00:00)
Title: Feature/rspec

Hey dude,

I had a look through the code, and noticed that it's a wee bit dated. I thought I would spend a bit of time getting it up to scratch, because I think that it could be a really useful application if it keeps getting worked on.

I plan to do the following things:

* Move `IndexController` to `PagesController` (IndexController is a confusing name)
* Make sure models are being created on their parents (e.g. Reviews controller#create should be used to create a review on a toilet, but instead it creates a review from params)
* Upgrade to Rails 3.2
* Move assets to asset pipeline

...but of course, all this is in the future. Before I started, I wanted to improve the spec suite to cover all current models and controllers, which is what this pull request does. The only controllers I haven't specced are the API controllers - this is because I think, looking at the amount of duplication, that it's better to merge this stuff into the normal controllers, and just have them respond with JSON where necessary.

Feel free to comment on this!