xbmc/xbmc — pull request #1618 by jmarshallnz (2012-10-14 09:23:15+00:00)
Title: Cached video art updating for Eden->Frodo

The Oct14 commits are all that matters - depends on #1609.

The current solution for Eden->Frodo art update is a backward compatibility routine that essentially re-downloads (or re-caches if the user has local art) each piece of art. It can screw up if the URLs stored in the video database are stale (e.g. themoviedb.org changes their URL layout a couple years ago).

Also, it places an unreasonable burden on our good friends at thetvdb.org and themoviedb.com.

We thus instead have a threaded updater that goes and grabs the previously cached art for an item (by resurrecting the old thumbnail crc code) and copies that as the cached art for the original artwork (local or online), flagging the image as "don't check for updates".

This is IMO the nicest way we can do it for Eden users updating to Frodo.

The only additional thing we could consider would be also checking the aspect ratio of the image and assigning to poster or banner (for shows). IMO this really isn't needed, as the user is only going to have one or the other, and skins should be falling back to the thumb image anyway.

@cptspiff: This introduces a significant chunk of code, but it is clearly split off from the rest, so will be easy to remove for Frodo+1.