taglib/taglib — pull request #80 by rsjtdrjgfuzkfg (2012-10-12 20:06:26+00:00)
Title: Virtual PropertyMap, read PropertyMap from TagUnion

First of all thanks for merging the last pull request.

When accessing a TagUnion currently there is no way to use other properties than the default ones. Also the PropertyMap methods are not virtual, so individual casting would be required to access additional tag fields (that are not accessible directly via the Tag class).

The attatched commit fixes both issues for me. I also marked the setProperties methods as virtual for constancy, even though for my specific project (Nightingale, fork of Songbird) they are not required, as the writing is tag-specific there.

I personally think having a unified, simple tag reading is a good thing, however I could understand if you want to force developers to not access the PropertyMap without knowing what tag types are available (-> what keys are to be used with that specific tag). I'm open for discussion, also if you have another idea how to solve this issue.