sergiogonzalez/liferay-portal — pull request #398 by KocsisDaniel (2012-10-12 15:00:24+00:00)
Title: [TECH SUPPORT] LPS-30361

Hi Sergio,

we changed the points you requested before, but there are 2 things that maybe questionable:

- we add an extra log into the OpenId action, because based on the application logic if we found already one user with the openId we log him in, otherwise try to add as a new user. So when the exception thrown we are sure we don't have one more user with the same openId. Only when a concurrent thread pass a user with the same Id can this happen, and we declared it a non-usual one, so we add an extra log message. Please feel free to remove if you think it is unnecessary.

- we tried the error-marker tag with the control panel section name: open-id, but it never shoved the right section with the error but the first section (details) with a generic error message, and we have to go manually to the openid tab to see the real error message. With value="openId" it works well.

Thanks,
Daniel