jmcnamara/pod-simple-wiki — pull request #2 by pragmatic (2012-10-07 16:41:12+00:00)
Title: Add options for MediaWiki output beautifying

Hi John,

I have re-worked my modifications using the feedback you gave as guidance. I agreed with all your suggestions and points raised, and I have tried to incorporate them into this new pull request. Now the default action if no options are passed is to produce exactly the same output as the previous commit by yourself. Thanks for spending the time to go through it, it was useful reality check to be reminded that with my enthusiasm to get my modifications added quickly, I'd overlooked a few (critical) points.

A quick summary of the changes:
- Added an extra option ```transformer_lists``` to make my list modifications only when this option is enabled.
- Tried to make the option names more descriptive.
- Tests created for each individual new option.
- Documentation added for the options in the POD.
- Reverted the case changing of all module file names and references in the code and documentation back to their original state.

Further on the last point, I had originally started off by writing a new subclass of the Mediawiki module but was unhappy because of the naming restrictions. I then later decided to make the output formatting changes to the existing module as this seemed a cleaner approach, but I left in those modifications, which of course in hindsight may have broken many people's installations. I would perhaps suggest for a future update leaving the existing module names as-is, but removing the case changing function calls in Pod::Simple::Wiki::new(), so as to allow potential future sub-classes freedom in choosing their case, although at this stage I'm thinking I've probably dwelled too long on the aesthetics of the module names!

Regards,
Peter Hallam