jbossas/jboss-as — pull request #3187 by jmesnil (2012-10-05 12:41:22+00:00)
Title: [AS7-5683] upgrade to HornetQ 2.3.0.BETA1

Do not merge, there are outstanding issues related to Netty upgrade.

# Issue with Netty dependency

HornetQ 2.3.0.BETA1 requires Netty 3.4.5.Final (groupId=io.netty).
In this PR, I also upgraded netty for the web subsystem
=> check with them that they are ok to upgrade

I left the dependency to Netty 3.2.6.Final (groupId=org.jboss.netty). I first removed it but the test suite complained about bad dependencies:

[INFO] --- maven-enforcer-plugin:1.0:enforce (ban-bad-dependencies) @ jboss-as- testsuite ---
[ERROR]
Dependency convergence error for org.jboss.netty:netty:3.2.5.Final paths to dependency are:
+-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
+-org.jboss.as:jboss-as-build:7.2.0.Alpha1-SNAPSHOT
+-org.jboss.as:jboss-as-core-model-test:7.2.0.Alpha1-SNAPSHOT
+-org.jboss.as:jboss-as-model-test:7.2.0.Alpha1-SNAPSHOT
+-org.sonatype.aether:aether-connector-asynchttpclient:1.13.1
+-com.ning:async-http-client:1.6.5
+-org.jboss.netty:netty:3.2.5.Final
and
+-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
+-org.projectodd.stilts:stilts-stomp-client:0.1.26
+-org.projectodd.stilts:stilts-stomp-api:0.1.26
+-org.jboss.netty:netty:3.2.1.Final
and
+-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
+-org.projectodd.stilts:stilts-stomp-client:0.1.26
+-org.projectodd.stilts:stilts-stomp-common:0.1.26
+-org.jboss.netty:netty:3.2.1.Final
and
+-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
+-org.projectodd.stilts:stilts-stomp-client:0.1.26
+-org.jboss.netty:netty:3.2.1.Final
and
+-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
+-org.projectodd.stilts:stilts-stomplet-server-core:0.1.26
+-org.projectodd.stilts:stilts-conduit-server-core:0.1.26
+-org.projectodd.stilts:stilts-stomp-server-core:0.1.26
+-org.jboss.netty:netty:3.2.1.Final
and
+-org.jboss.as:jboss-as-testsuite:7.2.0.Alpha1-SNAPSHOT
+-org.projectodd.stilts:stilts-stomplet-server-core:0.1.26
+-org.projectodd.stilts:stilts-stomplet-api:0.1.26
+-org.projectodd.stilts:stilts-stomp-server-spi:0.1.26
+-org.jboss.netty:netty:3.2.1.Final

I looked at some dependencies and I could not find a more recent version of Stilts that was using Netty 3.4.x

As the PR stands, it looks ok but ugly.
* Netty 3.4.5.Final (groupId=io.netty) is used by AS7 codebase
* Netty 3.2.6.Final (groupId=org.jboss.netty) is used by AS7 test suite

Is it acceptable to have 2 different versions of Netty like this or do we have to upgrade the test suite and its dependencies too (some are outside JBoss, eg org.sonatype.aether)

# Management model changes

I ran the tool to compare the model version to AS7 7.1.2.Final
I have only included the reports relevant to this patch.

--- Problems for relative address to root ["deployment" => "*","subdeployment" => "*","subsystem" => "messaging","hornetq-server" => "*"]:

=> see below

--- Problems for relative address to root ["deployment" => "*","subsystem" => "messaging","hornetq-server" => "*"]:

=> see below

====== Resource root address: ["subsystem" => "messaging"] - Current version: 1.2.0; legacy version: 1.1.0 =======

--- Problems for relative address to root ["hornetq-server" => "*"]:
Missing attributes in current: []; missing in legacy [backup-group-name, check-for-live- server, replication-clustername]
Missing parameters for operation 'add' in current: []; missing in legacy [backup-group- name, check-for-live-server, replication-clustername]

=> 2 new attributes for hornetq-server resource
=> same warning on the add operation

Different 'deprecated' for attribute 'clustered'. Current: {
"since" => "1.2.0",
"reason" => "To create a clustered HornetQ server, define at least one cluster-connection."
}; legacy: undefined
Different 'deprecated' for attribute 'live-connector-ref'. Current: {
"since" => "1.2.0",
"reason" => "Deprecated. This attribute is no longer used."
}; legacy: undefined

=> clustered & live-connector-ref are deprecated

--- Problems for relative address to root ["hornetq-server" => "*","broadcast-group" => "*"]:
Missing attributes in current: []; missing in legacy [jgroups-stack, jgroups-channel]
Different 'nillable' for attribute 'group-address'. Current: true; legacy: false
Different 'alternatives' for attribute 'group-address'. Current: [
"socket-binding",
"jgroups-stack",
"jgroups-channel"
]; legacy: ["socket-binding"]
Different 'nillable' for attribute 'group-port'. Current: true; legacy: false
Different 'alternatives' for attribute 'group-port'. Current: [
"socket-binding",
"jgroups-stack",
"jgroups-channel"
]; legacy: ["socket-binding"]
Different 'alternatives' for attribute 'local-bind-address'. Current: [
"socket-binding",
"jgroups-stack",
"jgroups-channel"
]; legacy: ["socket-binding"]
Different 'alternatives' for attribute 'local-bind-port'. Current: [
"socket-binding",
"jgroups-stack",
"jgroups-channel"
]; legacy: ["socket-binding"]
Different 'alternatives' for attribute 'socket-binding'. Current: [
"group-address",
"group-port",
"local-bind-address",
"local-bind-port",
"jgroups-stack",
"jgroups-channel"
]; legacy: [
"group-address",
"group-port",
"local-bind-address",
"local-bind-port"
]

=> 2 new attributes for broadcast-group. they are alternatives to socket-binding, group-address & group-port
=> same warning on the add operation

--- Problems for relative address to root ["hornetq-server" => "*","cluster-connection" => "*"]:
Missing attributes in current: []; missing in legacy [call-failover-timeout]

=> 1 new attribute for cluster-connection
=> same warning on the add operation

--- Problems for relative address to root ["hornetq-server" => "*","connection-factory" => "*"]:
Missing attributes in current: []; missing in legacy [call-failover-timeout]

=> 1 new attribute for connection-factory
=> same warning on the add operation

--- Problems for relative address to root ["hornetq-server" => "*","discovery-group" => "*"]:
Missing attributes in current: []; missing in legacy [jgroups-stack, jgroups-channel]

=> 2 new attributes for broadcast-group. they are alternatives to socket-binding, group-address, group-port, local-bind-address & local-bind-port
=> same warning on the add operation

Different 'nillable' for attribute 'group-address'. Current: true; legacy: false

=> the group-address can be nil (if there is a socket-bindings or jgroups-stack alternative)

--- Problems for relative address to root ["hornetq-server" => "*","pooled-connection-factory" => "*"]:
Missing attributes in current: []; missing in legacy [initial-message-packet-size, compress-large-messages, call-failover-timeout, use-auto-recovery, initial-connect-attempts]

=> new attributes for pooled CF