theforeman/puppet-foreman_proxy — pull request #22 by GregSutcliffe (2012-10-04 17:36:47+00:00)
Title: Params

This is as clean as I could get it - we can't put the $ip_temp / $ip code in params.pp because then you can't override $dhcp_interface as a class parameter. Putting it in any other class is just moving the ugly code.

So, I put it back in proxydhcp where @ekohl had it to start with. I've made it slightly more obvious as to what's going on with some comments, and the array handling is in the too. I've tested it with a single ip override and a string of "ip1,ip2", as well as testing it with the defaults. Seems fine

Good enough?