killbilling/recurly-java-library — pull request #3 by krisfoster (2012-10-03 19:58:56+00:00)
Title: Changes as discussed

Hi,

Here is the pull request, as discussed.

*CAUTION* : How prices / currencies have been handled has changed as I
couldn't get what was there working (`Map` to
represent an amount with a currency). So you may want to check that
this will not affect anything you are using `Plan` or `AddOn` for.

If this is an issue any feedback on how to get this working would be
great and I am happy to implement the changes - time allowing.

Anyway... onto the pull request.

Unit test are all passing and, very roughly, the following stuff has been added:

* Subscriptions creation
* Deleting plans
* Addons - not sure if this was there when I forked but you can create and query them now
* Unit tests now try to clean up the records they are creating within recurly
* Some debug output that dumps the comms back and forth (switched on with JVM env var)
* Setting page size for all gets - has some issues when the number of items being returned got beyond the max size that recurly would return

Forgot to add the following to the read-me which is the list of JVM vars that you can use:

* `recurly.debug` : set to true to switch on tracing of the messages, through log.info
* `recurly.page.size` : set to an int and sets the page size on queries (should be runtime config really though)

Do have a check of this before you accept though - and please do cast your eyes over the code. At least one thing is a little bit 'hokey' and will need resolving:

* The way currencies are dealt with. Current solution is not really much of a solution and I would appreciate any feedback on that. Originally you were using : `Map`, but I could not get this to work

Cheers,

Kris