rapid7/metasploit-framework — pull request #847 by todb-r7 (2012-10-02 01:46:58+00:00)
Title: Bring a little sanity to msfupdate

This fixes up some things that bug me about msfupdate. Favoring instance variables over explicit assignment of nil, avoiding `Array#push` and `Array#shift` on `ARGV` directly, little things like that.

This all came up while testing and grokking msfupdate. Turns out, svn.metasploit.com is really, really slow. Git SVN looks very promising, and working out how to switch out an active SVN repository to github without too much disruption.

That all is for another pull request. This PR just tries to make things more sane.