opscode/chef_wm — pull request #26 by mmzyk (2012-10-02 04:03:09+00:00)
Title: Review of user deletion guards in sf/OC-2298

@seth I am opening this pull request because I'd like you to look at the last commit from 10/1. It contains the logic that attempts to prevent a user from deleting the last admin client. It's somewhat involved and I think with more love it could be made cleaner.

That said: there is one giant whole right now: it won't stop a client from making a request to delete the admin user. I don't know how big an issue this is, but I discovered it because in testing from shef the user is a client user and so the logic wasn't preventing the requests from deleting the last admin user.

Let me know what you thin.