OpenSC/OpenSC — pull request #94 by bscottm (2012-09-28 19:01:28+00:00)
Title: Staging

Fix various warnings encountered when configured with "--enable-strict", such as integer conversions, unused locals and unused static functions. Also add "-Wno-unused-parameter" to the compiler's command line to reduce unused parameter warnings to a dull roar.

Unused static functions are clearly marked with "#if I_AM_ACTUALLY_USED_SOMEDAY" -- if these functions should be deprecated, then they are clearly marked and easy to remove.

There are also a few places where const qualifiers are clearly violated and commented as such in the code. This requires some thinking as to whether the function prototype and function pointer prototype need to be updated to allow mutability.

Yeah, it's a little bit of a code audit.