whimboo/mozmill-automation — pull request #23 by whimboo (2012-09-28 16:17:32+00:00)
Title: Fix broken handling of invalid binaries on OS X

When you are running the following command on OS X you will end up with an not helpful failure:

$ testrun_l10n firefox-15.0.1.en-US.win32.exe
Traceback (most recent call last):
File "/Volumes/data/code/mozmill-automation/2.0/mozmill_automation/testrun.py", line 184, in run
self._folder = p.search(self.binary).group()
AttributeError: 'NoneType' object has no attribute 'group'
Traceback (most recent call last):
File "/Volumes/data/envs/ma/bin/testrun_l10n", line 8, in
load_entry_point('mozmill-automation==0.1', 'console_scripts', 'testrun_l10n')()
File "/Volumes/data/code/mozmill-automation/2.0/mozmill_automation/testrun.py", line 425, in l10n_cli
exec_testrun(L10nTestRun)
File "/Volumes/data/code/mozmill-automation/2.0/mozmill_automation/testrun.py", line 411, in exec_testrun
cls().run()
File "/Volumes/data/code/mozmill-automation/2.0/mozmill_automation/testrun.py", line 271, in run
self._repository.remove()
AttributeError: 'L10nTestRun' object has no attribute '_repository'

Lets throw a better suited exception and ensure that we only call self._repository.remove() when there is one.