arasfeld/RoyalSociety — pull request #1 by greggjs (2012-09-26 15:36:42+00:00)
Title: Code Review

First, I noticed you didn't name your member variables right, so I fixed that for you. Remember, all member variables of a class in the coding style we're using have an underscore following them (variable_name_)

Also, I noticed you did not have a constructor for your node. You had Node.h, but not any Node.cpp. I did not want to add any files to your project, but you should make at least a default constructor for any class.

I also noticed you drew everything pixel by pixel. You did not have to make yourself do this, you could have instead just called "gl::drawSolidRect(x, y, h, w);". It does the same exact thing in one line of code, with a great way to draw shapes just by importing "cinder/gl/gl.h" a lot of good methods in there for drawing various textures and shapes.

You only seemed to draw 3 rectangles and made them loop around. Maybe you should have tried to add some more interactivity to your program. Nice job on the help page though.

You also did not need mouseDown(). If you're not using a method, you should probably just delete it, unless you just forgot and were planning on using it. Try adding some click-ability to your program next time.

Otherwise, good job.