marshast/ThingsAtopThings — pull request #1 by anglessw (2012-09-26 12:49:18+00:00)
Title: Code Review

The code that is there is really excellent. I fixed a few minor things such as instance variable initialization in loops and I did my best to cut down on unnecessary function calls. Some of the PolyLine stuff that you used was great. You were definitely sure to utilize the methods already available to you instead of writing unnecessary code. This is something I think we all could improve upon, and you certainly are proficient in that regard. All the code you have there has excellent style and is very succinct! Every solution you implemented was elegant and didn't seem to waste time or code. A qualm I had with the design was the fact that you had a class that was a linked list, a shape, and a node all in one. I suppose depending on how strict of an OO programmer you are, this is okay. I personally would have tried to separate these things, but you made it work well (quite well, I may add). I was a bit confused as to why I would click and a letter would occasionally come to the front, but not all the time. The reverse method worked fine, but I believe the bounding box for the shapes was not the best choice since the letters were so close together.

All in all, really excellent code! You do a lot with a little, which is always a plus. I was initially in awe when looking at your code; very professional and succinct.