xbmc/xbmc — pull request #1479 by herrnst (2012-09-25 20:23:29+00:00)
Title: GUIInfoManager/LCD/LCDproc: Cleanup string handling & fix display of Play/Pause/Fwd/Rwd custom chars

This PR (the two contained commits) does the following:

- StringToLCDCharSet() and the only call in XLCDproc.cpp get removed. The function seems to be some leftover from the Xbox code, where (so I guess?) displays got addressed directly. This should not be needed anymore as any conversion should be handled by LCDproc, so we don't interfere beforehand.

- Fix up display of custom characters by writing the correct char codes for Play/Pause/Fwd/Rwd icons. These get written by $INFO[LCD.PlayIcon] and seem to have been "parsed" to their correct ones by StringToLCDCharSet(). However, this also gets handled by LCDproc.

Note: This was already reported at least as small part of Trac #10324, so some credit should go to user "oleksiy".

Aparently can not test this with other displays than my Imon, but at least should not cause any stability harms.