jordankomnick/HW02Final — pull request #1 by ajduberstein (2012-09-25 21:20:48+00:00)
Title: Code review for HW02

Jordan,

I'll document the changes I made and their justification here:
-Member variables all received a trailing underscore, according to the Google standard.
-Camel-casing remained for those member variables that were objects. Dr. Brinkman set the precedent for this in HW01.
-On line 66, I erased your comment, to adhere to the DRY Principle, since it's already stated in your code.
-The same is true with other comments throughout the code.
-Indentation was corrected and made consistent.
-The long variable name "location_before" was changed to "prev," which is shorter and communicative.
-I removed your remove method, since it's unutilized.
-I also cut your mouseDown method
-I moved the LinkedList::reverse() method call to your keyDown method. DRY Principle, again.

I have some suggestions that are substantial architectural decisions and not just embellishments or hygienic practices. I've left them for your consideration but will leave it at your discretion to implement them or not:
-I'm a fan of .h files. They make code easier to read by giving a great preview of what's to come and shortening your .cpp by just a little bit.
-Consider structs instead of classes if all your methods are going to be public. It quickly communicates your intention for the code.
-Specify your root node as a member variable. This will make everything a great deal easier.

Best,
Andrew