caolan/async — pull request #179 by cliffano (2012-09-25 08:58:48+00:00)
Title: Replace constructor === Array checks with safer Array.isArray

MDN Object constructor reference page ( https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/constructor ) states that constructor property can be changed and it is not always safe to believe in constructor function.

I found an issue when using the latest version of async with the latest version of sandboxed-module ( https://github.com/felixge/node-sandboxed-module ) where async.parallel thinks that tasks variable is not an array even though it is actually an array. This is caused by "tasks.constructor === Array" returns false, while Array.isArray(tasks) returns true.
This is very likely to be caused by sandboxed-module issue 13 ( https://github.com/felixge/node-sandboxed-module/issues/13 ) which changes the value of constructor property, and is still an open issue.

Granted that this is not an async bug, but it would be better if async doesn't rely on constructor property which can be modified by other modules, and uses Array.isArray instead.