OneBusAway/onebusaway-application-modules — pull request #28 by bdferris (2012-09-23 22:35:42+00:00)
Title: Issue #4 - Refactor SituationQueryBean

As discussed a while back, I'd like to propose cleaning up the service alert query API in the TransitDataService API. To recap the discussion, the SituationQueryBean would be refactored to match the OBA / SIRI / GTFS-realtime "affects" clause model, where the query mechanism for alerts uses the same style of affects clauses as the alerts themselves. This pull request implements the proposed change.

I know it's been months since we last had a discussion around this, but there are some bugs in the onebusaway-webapp admin interface for editing service alerts that would be resolved by this pull request. However, it would also break any existing users of the SituationQueryBean interface, so care must be taken to modify any downstream clients after this change.

Thoughts?