pioneerspacesim/pioneer — pull request #1528 by johnbartholomew (2012-09-22 15:23:35+00:00)
Title: Minor view cleanup

This is a tiny bit of cleanup to reduce the hackiness of the fix for #1493. I had aimed to go further with this, but it got a bit complicated and with new-ui on the way it doesn't seem worth putting much time into it.

This replaces `View::ShowAll` and `View::HideAll` with `View::Attach` and `View::Detach`, so that `ShowAll` and `HideAll` never mess with the set of base widgets. The `Gui::Fixed` destructor is cleaned up so that it doesn't mess with the base widget set either.

Also, `Gui::Container::{Append,Prepend}Child` assert that the child doesn't already have a parent and isn't already in the container.