sergiogonzalez/liferay-portal — pull request #368 by ealonso (2012-09-21 07:11:50+00:00)
Title: LPS-28165

Hey Brian,

We had a couple of questions about this pull.

First, we are not fully sure about the idea of having a threadlocal and disable it when calling DLApp from PortletFileRepository. The thing is that there are many things that are not needed, and after talking with @caorongjin he suggested that we should have something like this to disable everything that it's not needed for performance reasons.

The other thing is about the name of methods like GetFolder. The issue is that this method is not only getting a folder, but also creating it in case it doesn't exist. There are many other methods in the portal like this, called getXXXX or isXXXX, but it does more things, not only getting or checking.
What do you think about changing these methods name to something like getAddFolder?

Reviewed by @sergiogonzalez

@caorongjin