xbmc/xbmc — pull request #1452 by fetzerch (2012-09-20 20:58:40+00:00)
Title: [pvr] Show resume indicator for recordings + some cleanups

This PR contains some smaller changes closely related to the 'set play count' / 'set play position' on the addon features.

First, it adds the resume indicator (arrow) to the recordings view so that you see the partly watched recordings at a glance. Also when a recoding is marked as watched via the context menu, we now clear the resume bookmark on the backend (SetLastPlayedPosition).

In addition, the PR adds some cleanups. Whereas 'set play count' / 'set play position' are quite similar, they're currently called from completely different locations:
When the player stops, the play count is set in the video database and the play position is set in dvdplayer.
I moved both now to SaveFileStateJob.

@Red-F You are mentioning that you had this in dvdplayer on purpose: https://github.com/opdenkamp/xbmc/pull/536
If I get the whole player concept right, it should go to SaveFileStateJob to have it also working on rpi and other platforms. Or is dvdplayer used everywhere? Maybe you could explain your point and we can get it fixed.

@opdenkamp I'd also like to unify the method calls a bit. Is it ok to move Set/GetRecordingLastPlayedPosition from PVRManager to PVRRecording (where SetPlayCount is)? Or better move SetPlayCount into the manager? I'd then add an additional commit.

Cheers,
Christian