okfn/ckan — pull request #134 by rgrp (2012-09-19 19:26:21+00:00)
Title: [#2935,datapreview] Patch datapreview JS for new datastore

datapreview JS had been updated in 2733 but these don't work in master as demo / v2.0 branch does not use old JS. This patch applies patches to new datapreview.js and upgrades to latest recline.js (to fix various issues) including upgrading some vendor deps.

## Some Asides

Some asides from doing this work that could be useful to other people coding on JS stuff ...

When I tried to run CKAN from master I got errors like:

main.debug.css does not exist

Everntually worked out there was new build system (at least for dev mode) and guessed I had to do:

node install less && node install node watch
bin/less

Would be nice to document this properly somewhere ...

Also noticed we now seem to have 2 JS variables named "ckan":

CKAN - Module
ckan - object with all the old config attributes (used to be on CKAN)

Plus:

CKANEXT - may just be holdover from obsolete application.js

Lastly I note we still have application.js and all the old vendor stuff still around. I guess this is for some form of backwards compatability but it does make code pretty confusing. Perhaps worth adding something pretty clear in README or developer guide in main docs about all of this.